add framework for rendering widgets #101
Conversation
There was a problem hiding this comment.
@jwildfire , this is genius! Now are half way towards bringing {safetyexploreR} back! I like the yaml mapping from sg V2, which allows users to obtain from the UI. This saves tons of the R function parameter documentation that @bzkrouse did before! 😄 This solves the namespace issue and we don't have export a function for each widget.
Would it make sense to also add Shiny binding functions like in {safetyGraphics} prepareChart function? Something like below?
sgV2's chartsTab module is great, however, the following binding might add flexibility to drop a widget to a Shiny app without having to use tab UI.
#' @export
meta_widgetOutput <- function(outputId, widgetName, width = "100%", height = "400px") {
htmlwidgets::shinyWidgetOutput(outputId, widgetName, width, height, package="safetyCharts")
}
#' @export
meta_renderWidget <- function(expr, widgetName, env = parent.frame(), quoted = FALSE) {
widgetOutput <- function(outputId, width = "100%", height = "400px") {
htmlwidgets::shinyWidgetOutput(outputId, widgetName, width, height, package="safetyCharts")
}
if (!quoted) { expr <- substitute(expr) } # force quoted
params <- list(
expr = expr,
outputFunction = widgetOutput,
env = env,
quoted = quoted,
cacheHint = "auto"
)
do.call( htmlwidgets::shinyRenderWidget, params)
}
|
Thanks for the review @xni7. I do like the idea of extending this a bit further, and maybe migrating/reusing a bit more of the chart rendering in safetyGraphics here in safetyCharts. Going to go ahead and release this first bit with v0.3 and then we can discuss extensions for future releases. Filed #102 so we don't lose track of the shiny binding idea. |
Overview
Inspired by a few requests for customizations to hepExplorer that aren't covered in safetyGraphics. This adds a
render_widget()helper function for rendering widgets directly, which is basically just a reusable function created from safetyGraphics chart export code for widgets (generated fromsafetyGraphics::makeChartExport).hepExploreris a wrapper that adds some basic defaults and the ability to pass custom settings via ...@bzkrouse @xni7 Take a look and see what you think! Can discuss whether it's worth building this out further or leaving it as a simple behind-the-scenes utility next time we chat.
Test Code